Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Upgrade Scripts to Dockernet #307

Merged
merged 8 commits into from
Oct 19, 2022
Merged

Added Upgrade Scripts to Dockernet #307

merged 8 commits into from
Oct 19, 2022

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Oct 19, 2022

Closes: #XXX

Context and purpose of the change

  • Added functionality to dockernet to easily test upgrades
  • See README for usage

Brief Changelog

  • Added two new stride dockerfiles - one that builds the old binary, and one that runs both binaries with cosmovisor. The reason for having two images is so that you don't have to re-install cosmovisor and the old binary every time you rebuild
  • Added a submit_upgrade.sh script to propose and vote on the upgrade

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

@sampocs sampocs marked this pull request as ready for review October 19, 2022 15:45
@sampocs sampocs added the v2 label Oct 19, 2022
@sampocs sampocs changed the title Added Upgrade Script to Dockernet Added Upgrade Scripts to Dockernet Oct 19, 2022
Copy link
Contributor

@shellvish shellvish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and honestly an extremely logical flow for running the upgrade logic. Let's test this out with our first upgrade!

README.md Show resolved Hide resolved
scripts/upgrades/view_proposal_status.sh Outdated Show resolved Hide resolved
@sampocs sampocs merged commit ceff377 into main Oct 19, 2022
@sampocs sampocs deleted the dockernet-upgrades branch January 6, 2023 17:39
sontrinh16 pushed a commit to notional-labs/stride that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants